dfgsurvey/2026
Watch
1
0
Fork
You've already forked 2026
 1
Code Pull requests Packages Activity

Add ordering of PromotionStatus fields #2

Merged
jsheunis merged 2 commits from msz/2026:push-tsxwmkqzoqsn into main 2026-10-05 14:16:42 +00:00
Conversation 2 Commits 2 Files changed 1 +15 -1
msz commented 2026-10-05 08:40:44 +00:00
Member
Copy link

This makes them appear when adding a PromotionStatus without having to toggle "All fields" (order < 1M). Previously, editing PromotionStatus opened without any field visible.

Didn't test locally, but I think that's it.

This makes them appear when adding a PromotionStatus without having to toggle "All fields" (order < 1M). Previously, editing PromotionStatus opened without any field visible. Didn't test locally, but I think that's it.
This makes them appear when adding a PromotionStatus without having to
toggle "All fields" (order < 1M). Previously, editing PromotionStatus
opened without any field visible.
jsheunis commented 2026-10-05 12:54:21 +00:00
Owner
Copy link

can you also add the associated property group (order value does not really make a difference here):

property_groups:
  ...
  promotion_status:
    title: Promotion Status
    order: 4

  ...

i tested this locally and it works.

can you also add the associated property group (order value does not really make a difference here): ```yaml property_groups: ... promotion_status: title: Promotion Status order: 4 ... ``` i tested this locally and it works.
jsheunis stopped working 2026-10-05 13:04:54 +00:00
3 minutes 22 seconds 
Order value does not really make a difference because, unlike most other
groups, it is only used on PromotionStatus class which is a property
under Person (and is the only group there). I'm assuming reusing
status_group_specific for PromotionStatus items could also work for
similar reasons, and be more consistent with other classes.

Suggested-by: Stephan Heunis <s.heunis@fz-juelich.de>
msz commented 2026-10-05 14:03:16 +00:00
Author
Member
Copy link

Done as suggested - this made me realize that I could have re-used the status_group_specific group for the PromotionStatus slots. I didn't do this because it was used for items on Person, but I guess it's a combination of fields that are defined for the class and the annotation that matters, and either way works...

Done as suggested - this made me realize that I could have re-used the `status_group_specific` group for the PromotionStatus slots. I didn't do this because it was used for items on Person, but I guess it's a combination of fields that are defined for the class and the annotation that matters, and either way works...
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Total time spent: 3 minutes 22 seconds
jsheunis
3 minutes 22 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
dfgsurvey/2026!2
No description provided.