q04/www.trr379.de
q04/www.trr379.de
10
1
Fork 2
Code Issues Pull requests Projects Activity Actions

Adapt workflows to tooling changes #25

Merged
mih merged 2 commits from msz/www.trr379.de:msz-fix-ci-2 into main 2026-03-29 20:02:38 +00:00
Conversation 1 Commits 2 Files changed 2 +3 -3
msz commented 2026-03-13 13:57:05 +00:00
Contributor
Copy link

I made some small changes in the q02/pool-publication-page:

  • one makes the filter CLI more consistent (but would break workflows here)
  • one allows using inlined attributions

This PR adapts the workflows to these changes. Changes here are very small, but the what & why is explained in detail in commit messages.

I made some small changes in the [q02/pool-publication-page](https://hub.trr379.de/q02/pool-publication-page): - one makes the filter CLI more consistent (but would break workflows here) - one allows using inlined attributions This PR adapts the workflows to these changes. Changes here are very small, but the what & why is explained in detail in commit messages.
The CLI of join-association.py was changed to require explicit output
declaration (with - being stdout), making it consistent with other
filters in that project, in (1). This commit accounts for that change.

7f894c5bd0
Inlining roles in attribution allows looking up their mappings. This
means that whichever role qualifies as an author attribution (as
opposed to, e.g., a funding attribution) can be expressed in the pool
by declaring a broad mapping. Previously, we relied on a narrow
mapping of an author to be declared in the code.

This is enabled by two changes done elsewhere in recent weeks:

- query-things (former query-research-group): inline-records will no
  longer error when the requested property is not present (1)

- pool-publication-page: publication.py will also work with inlined
  roles; if the role is inlined it will check broad_mappings before
  resorting to a predefined list (2)

One thing to note is that now if attributed_to::roles is not present,
inline-records will drop the entire attribution (instead of keeping it
and inlining just the object). This is inconsequential, as
publication.py would only consider attributions with roles anyway.

(1) e4c9d4498e
(2) 35c21b9123
a.wagner commented 2026-03-18 12:54:27 +00:00
First-time contributor
Copy link

I don't have permission to merge or review, but given that the workflow has been failing the past days (to the action) and this PR fixes that, I wanted to leave an encouragement here.

I don't have permission to merge or review, but given that the workflow has been failing the past days ([to the action](https://hub.trr379.de/q04/www.trr379.de/actions?workflow=contributors-projects.yml&actor=0&status=0)) and this PR fixes that, I wanted to leave an encouragement here.
mih merged commit bd7be116b7 into main 2026-03-29 20:02:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
q04/www.trr379.de!25
No description provided.